Fix backwards-in-time solve for AbstractSRKs#599
Fix backwards-in-time solve for AbstractSRKs#599sammccallum wants to merge 1 commit intopatrick-kidger:mainfrom
Conversation
|
LGTM! |
|
Right, turns out this is a slightly more involved bug! The Lévy area term I think there is a choice for whether this should be directly handled by VBT or by the solvers themselves? Tagging 'the SDE lads' @andyElking and @lockwo for their thoughts? Btw, the original change ( |
|
Thanks for spotting this, Sam. Idk how the In terms of VBT, I think |
|
Yeah, that's what I thought and it semi-works: flipping the sign of |
|
Okay! I'll let you folks figure out how you want to tackle this, and since it looks like that might take a little time then I'll do a release on #600 in the mean time anyway. |
Fixes sign of
hinAbstractSRK. See #598.